Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/18846/7/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18846/7/src/kudu/client/client-test.cc@1134 PS7, Line 1134: ASSERT_EQ(FLAGS_test_scan_num_rows, CountRowsFromClient(client_table_.get())); > nit: Is it possible to move this check into DoTestScanWithStringPredicate? No, scanner->data_ is private. TestScanWithRequestId accesses it using friend method. http://gerrit.cloudera.org:8080/#/c/18846/7/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/18846/7/src/kudu/tserver/tablet_service.cc@2756 PS7, Line 2756: "tablet_id", scan_pb.tablet_id()); > nit: Maybe we can wrap the request_id in TRACE_EVENT? Ok. http://gerrit.cloudera.org:8080/#/c/18846/7/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/18846/7/src/kudu/tserver/tserver.proto@397 PS7, Line 397: If not set, generat > nit: If not set Done -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 06 Sep 2022 02:02:57 +0000 Gerrit-HasComments: Yes
