Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18846/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18846/6//COMMIT_MSG@16 PS6, Line 16: That is available to debug problem. Can you explain why request_id helps to troubleshoot problems? http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/tserver/tserver.proto@398 PS6, Line 398: optional bytes request_id = 6; Instead of passing a unique id to the ScanRequestPB, can we just collect and process server-side scan metrics that belong to the same query or kudu::client::KuduScanner in client only? Some useful metrics have already been passed to the client in ScanResponsePB.resource_metrics, maybe it can be used to analyze performance issues too. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 25 Aug 2022 08:47:26 +0000 Gerrit-HasComments: Yes
