Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 7: (5 comments) > Patch Set 6: > > (2 comments) http://gerrit.cloudera.org:8080/#/c/18846/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18846/6//COMMIT_MSG@16 PS6, Line 16: That is convenient to debug problem > Can you explain why request_id helps to troubleshoot problems? Request id can help to analyze the whole query process and which step it got stuck or failed. http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/client/client.h@2693 PS6, Line 2693: > Add documentation about this parameter in the comments. Done http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/client/client.h@2693 PS6, Line 2693: explicit KuduScanner(KuduTable* table); > +1 Done http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/tserver/tablet_service.cc@2756 PS6, Line 2756: VLOG(1) << "request_id: " << req->request_id() > I think these logs are only used when debuging, remove it or set it as a lo Done http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/tserver/tserver.proto@398 PS6, Line 398: optional bytes request_id = 6; > Instead of passing a unique id to the ScanRequestPB, can we just collect an Metrics can help to analyze why the query is slow, but can not to analyze why the query failed and which step it failed. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 05 Sep 2022 02:14:03 +0000 Gerrit-HasComments: Yes
