Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/client/client.h@2693 PS6, Line 2693: explicit KuduScanner(KuduTable* table, std::string request_id = ""); Overloading this constructor would be better from a binary compatibility perspective. http://gerrit.cloudera.org:8080/#/c/18846/6/src/kudu/client/client.h@2693 PS6, Line 2693: std::string request_id = "") Add documentation about this parameter in the comments. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 25 Aug 2022 21:14:30 +0000 Gerrit-HasComments: Yes
