Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19246 )
Change subject: WIP [compact] Increase chances of compaction for large number deltas ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet.cc@2469 PS1, Line 2469: double workload_score = 0; > If you are talking about workload_score, I think it may make more sense to Agree, we can make the max_limit_delta_size configurable. http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet.cc@2477 PS1, Line 2477: rowset_bytes nit: Do we want to call this delta_rowset_bytes? -- To view, visit http://gerrit.cloudera.org:8080/19246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2199ae3b777e75b15b60d8ad818cc6adc4f5fa3b Gerrit-Change-Number: 19246 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Nov 2022 20:09:02 +0000 Gerrit-HasComments: Yes
