Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19246 )
Change subject: KUDU-3406 [compaction] Increase chances of compaction for large number deltas ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19246/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19246/4//COMMIT_MSG@16 PS4, Line 16: To fix this, weight is given to the rowset compaction op if such : a case arises i.e. accumulation of deltas is huge. How max(1.0, x) weight is going to compare with flush-related operations whose score can go over hundreds? There was a thread about this in https://gerrit.cloudera.org/#/c/19246/1/src/kudu/tablet/tablet.cc@2483 If flush-related ops always take precedence over compaction with such a long queue of delta memstores, I don't think KUDU-3406 is going to be addressed with this approach. -- To view, visit http://gerrit.cloudera.org:8080/19246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2199ae3b777e75b15b60d8ad818cc6adc4f5fa3b Gerrit-Change-Number: 19246 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 21 Nov 2022 17:51:29 +0000 Gerrit-HasComments: Yes
