Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19246 )
Change subject: KUDU-3406 [compaction] Increase chances of compaction for large number deltas ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19246/4/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/19246/4/src/kudu/tablet/tablet_mm_ops.cc@151 PS4, Line 151: CountUndoDeltasForTests This takes into account all the rowsets and sums up the size of their undo delta blocks. However, the issue exposed in KUDU-3406 shows the problem happens when a single rowset accumulated too much data, not all of the rowsets in total. CompactRowSetsOp takes care just of a few rowsets during one run, so I'd think it's important to check for the amount of accumulated undo deltas per rowset, not total across all rowsets. -- To view, visit http://gerrit.cloudera.org:8080/19246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2199ae3b777e75b15b60d8ad818cc6adc4f5fa3b Gerrit-Change-Number: 19246 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 21 Nov 2022 18:09:16 +0000 Gerrit-HasComments: Yes
