Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19246 )
Change subject: WIP [compact] Increase chances of compaction for large number deltas ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/delta_tracker.cc@513 PS1, Line 513: undo_redo->EstimateSize(); > IIRC, cfile might contain compressed blocks, and from the memory profiles a This seem to be on-disk size as per the comments. But I will confirm from test logs in a while. http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/mock-rowsets.h File src/kudu/tablet/mock-rowsets.h: http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/mock-rowsets.h@162 PS1, Line 162: EstimateBytesInDeltas > I meant tests in compaction_policy-test.cc, but those might be rather testi Yes, the tests are performed to check general outcome of budgeted compaction policy and ensure that with increase in load the budget also either increases or remains the same and doesn't reduce. I can't think of a similar test case for this fix here. However, one test should be there to ensure delta compaction is given preference over other maintenance ops when applying certain workload that generates deltas frequently. I have this test in manual steps. Am in process of moving those steps to automated test. http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet.cc@2469 PS1, Line 2469: double workload_score = 0; > That was about max_limit_deltas_size, of course. Done http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet.cc@2477 PS1, Line 2477: rowset_bytes > nit: Do we want to call this delta_rowset_bytes? Done -- To view, visit http://gerrit.cloudera.org:8080/19246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2199ae3b777e75b15b60d8ad818cc6adc4f5fa3b Gerrit-Change-Number: 19246 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Nov 2022 12:17:12 +0000 Gerrit-HasComments: Yes
