Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19246 )
Change subject: WIP [compact] Increase chances of compaction for large number deltas ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet_mm_ops.cc@250 PS1, Line 250: double perf_improv_for_huge_deltas = tablet_->CollectAndUpdateDeltaStats(); : perf_improv = std::max(perf_improv, perf_improv_for_huge_deltas); I found a bug that is causing undo deltas not getting cleaned up even though compaction get scheduled. Please hold your review till tomorrow. By then, I should be able to fix that. -- To view, visit http://gerrit.cloudera.org:8080/19246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2199ae3b777e75b15b60d8ad818cc6adc4f5fa3b Gerrit-Change-Number: 19246 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Nov 2022 22:07:13 +0000 Gerrit-HasComments: Yes
