Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )
Change subject: server: link in kudu_jwt_util ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc@661 PS4, Line 661: LAGS_keytab_file) > How about std::make_shared<KeyBasedJwtVerifier>("", true)? Indeed using make_shared would be nicer, however in follow up patches the value of the jwt_verifier will be set based on configurations, so the separate variable will be needed anyways. http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644 PS9, Line 644: std::shared_ptr<JwtVerifier> jwt_verifier(std::make_shared<KeyBasedJwtVerifier>("", true)); > Same question here. empty jwks_uri does not provide valid JWKS. no, it is not a functional verifier, it's a placeholder, the actual values will be passed via config flags in the next patch: https://gerrit.cloudera.org/c/18471/5/src/kudu/server/server_base.cc#658 also I've added the Init() to the MessengerBuilder::Build() method -- To view, visit http://gerrit.cloudera.org:8080/18470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a Gerrit-Change-Number: 18470 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 12 Dec 2022 18:53:23 +0000 Gerrit-HasComments: Yes
