Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )
Change subject: server: link in kudu_jwt_util ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/18470/14/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: http://gerrit.cloudera.org:8080/#/c/18470/14/src/kudu/rpc/messenger.h@387 PS14, Line 387: JwtVerifier* jwt_verifier() const { return jwt_verifier_.get(); } This isn't a const-correct method. Maybe, remove this one altogether and use mutable_jwt_verifier() where necessary? https://isocpp.org/wiki/faq/const-correctness#return-const-ref-from-const-memfn -- To view, visit http://gerrit.cloudera.org:8080/18470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a Gerrit-Change-Number: 18470 Gerrit-PatchSet: 14 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 17:43:17 +0000 Gerrit-HasComments: Yes
