Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )
Change subject: server: link in kudu_jwt_util ...................................................................... Patch Set 12: (2 comments) > Patch Set 12: Verified-1 > > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/26878/ : FAILURE not sure why the IWYU build failed the last time, I'll re-trigger it http://gerrit.cloudera.org:8080/#/c/18470/10/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: http://gerrit.cloudera.org:8080/#/c/18470/10/src/kudu/rpc/messenger.h@387 PS10, Line 387: JwtVerifier* jwt_verifier() const { return jwt_verifier_.get(); } > This signature doesn't make much sense, and TidyBot posted about that. Done http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644 PS9, Line 644: .set_rpc_negotiation_timeout_ms(FLAGS_rpc_negotiation_timeout_ms) > Ah, I see: thanks for the pointer. Done -- To view, visit http://gerrit.cloudera.org:8080/18470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a Gerrit-Change-Number: 18470 Gerrit-PatchSet: 12 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 13:01:01 +0000 Gerrit-HasComments: Yes
