Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )
Change subject: server: link in kudu_jwt_util ...................................................................... Patch Set 10: (2 comments) Many Python tests have failed with error like Runtime error: Failed to load JWKS: Could not open JWKS file ''; No such file or directory IWYU isn't happy yet: http://jenkins.kudu.apache.org/job/kudu-gerrit/26876/BUILD_TYPE=IWYU/artifact/build/latest/test-logs/iwyu.log http://gerrit.cloudera.org:8080/#/c/18470/10/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: http://gerrit.cloudera.org:8080/#/c/18470/10/src/kudu/rpc/messenger.h@387 PS10, Line 387: JwtVerifier* const jwt_verifier() const { return jwt_verifier_.get(); } > warning: return type 'kudu::JwtVerifier *const' is 'const'-qualified at the This signature doesn't make much sense, and TidyBot posted about that. http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644 PS9, Line 644: std::shared_ptr<JwtVerifier> jwt_verifier(std::make_shared<KeyBasedJwtVerifier>("", true)); > no, it is not a functional verifier, it's a placeholder, the actual values Ah, I see: thanks for the pointer. With that, is it possible to leave jwt_verifier as a nullptr wrapper (i.e. not call Messenger::set_jwt_verifier()) if that's not a functional verifier anyways? -- To view, visit http://gerrit.cloudera.org:8080/18470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a Gerrit-Change-Number: 18470 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 12 Dec 2022 23:18:32 +0000 Gerrit-HasComments: Yes
