KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19608 )
Change subject: [master] exclude tservers at MAINTENANCE_MODE when leader rebalancing ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19608/2/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/19608/2/src/kudu/master/auto_leader_rebalancer-test.cc@236 PS2, Line 236: string command = Substitute("$0/kudu tserver state enter_maintenance $1 $2", : DirName(exe_file), : master_addresses, : mini_tserver->uuid()); : ASSERT_OK(Subprocess::Call(command)); Could you check the tserver state after the state set operation? http://gerrit.cloudera.org:8080/#/c/19608/2/src/kudu/master/auto_leader_rebalancer-test.cc@242 PS2, Line 242: mini_tserver->Restart(); Why we need do tserver restart here? -- To view, visit http://gerrit.cloudera.org:8080/19608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f85a675e69fd02a62e2625881dad2ca5e27acd9 Gerrit-Change-Number: 19608 Gerrit-PatchSet: 2 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 12 Mar 2023 04:16:27 +0000 Gerrit-HasComments: Yes
