Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19608 )
Change subject: [master] exclude tservers at MAINTENANCE_MODE when leader rebalancing ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/19608/4/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/19608/4/src/kudu/master/auto_leader_rebalancer-test.cc@215 PS4, Line 215: MaintenanceMode > Need prefix: Test DONE, and I should learn the standard style like this, where can I find it? http://gerrit.cloudera.org:8080/#/c/19608/4/src/kudu/master/auto_leader_rebalancer-test.cc@239 PS4, Line 239: ASSERT_OK(Subprocess::Call(Substitute("$0/kudu tserver state enter_maintenance $1 $2", > Add some comments. Done http://gerrit.cloudera.org:8080/#/c/19608/4/src/kudu/master/auto_leader_rebalancer-test.cc@253 PS4, Line 253: SleepFor(MonoDelta::FromSeconds(10 * FLAGS_auto_rebalancing_interval_seconds)); > This is a slow test. Maybe need add SKIP_IF_SLOW_NOT_ALLOWED(); This is a normal test for leader rebalancing, and FLAGS_auto_rebalancing_interval_seconds is 1s (very short) for these test cases. IMO, it's not necessary SKIP_IF_SLOW_NOT_ALLOWED. What's others' opinion? http://gerrit.cloudera.org:8080/#/c/19608/4/src/kudu/master/auto_leader_rebalancer.h File src/kudu/master/auto_leader_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/19608/4/src/kudu/master/auto_leader_rebalancer.h@79 PS4, Line 79: exclude_dest_uuids > How about: exclude_tserver_uuids? The two names, I think exclude_dest_uuids is better, it show the purpose. leader transfer request, is from source tserver to destination tserver. 'exclude_dest_uuids' means we exclude the destination tserver. http://gerrit.cloudera.org:8080/#/c/19608/4/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/19608/4/src/kudu/master/auto_leader_rebalancer.cc@251 PS4, Line 251: count > How about using: ContainsKey() Done -- To view, visit http://gerrit.cloudera.org:8080/19608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f85a675e69fd02a62e2625881dad2ca5e27acd9 Gerrit-Change-Number: 19608 Gerrit-PatchSet: 4 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 13 Mar 2023 09:09:18 +0000 Gerrit-HasComments: Yes
