Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19608 )

Change subject: [master] exclude tservers at MAINTENANCE_MODE when leader 
rebalancing
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19608/2/src/kudu/master/auto_leader_rebalancer-test.cc
File src/kudu/master/auto_leader_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/19608/2/src/kudu/master/auto_leader_rebalancer-test.cc@236
PS2, Line 236:   CHECK_OK(Env::Default()->GetExecutablePath(&exe_file));
             :   const string kudu_cli_path = DirName(exe_file);
             :
             :   ASSERT_OK(Subprocess::Call(Substitute("$0/kudu tserver state 
enter_maintenance $1 $2",
             :                        
> Could you check the tserver state after the state set operation?
Done


http://gerrit.cloudera.org:8080/#/c/19608/2/src/kudu/master/auto_leader_rebalancer-test.cc@242
PS2, Line 242:                   
> Why we need do tserver restart here?
To break the balanced(transfer all leaders of this tserver)



--
To view, visit http://gerrit.cloudera.org:8080/19608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f85a675e69fd02a62e2625881dad2ca5e27acd9
Gerrit-Change-Number: 19608
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Mon, 13 Mar 2023 04:32:50 +0000
Gerrit-HasComments: Yes

Reply via email to