Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19608 )
Change subject: [master] exclude tservers at MAINTENANCE_MODE when leader rebalancing ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/19608/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19608/5//COMMIT_MSG@7 PS5, Line 7: at nit: in http://gerrit.cloudera.org:8080/#/c/19608/5//COMMIT_MSG@9 PS5, Line 9: Now nit: Change to "Currently, " http://gerrit.cloudera.org:8080/#/c/19608/5//COMMIT_MSG@10 PS5, Line 10: Because of the sematics of : 'MAINTENANCE_MODE', Could you explain these semantics in the commit message? E.g. why is it not reasonable to transfer a leader to a tserver in maintenance mode? http://gerrit.cloudera.org:8080/#/c/19608/5/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/19608/5/src/kudu/master/auto_leader_rebalancer-test.cc@239 PS5, Line 239: tserve nit: tserver http://gerrit.cloudera.org:8080/#/c/19608/5/src/kudu/master/auto_leader_rebalancer-test.cc@263 PS5, Line 263: // Only 3 tserver includes 1 tserver is maintenance mode. : // So, this cluster can not reach a rebalanced state of leaders. nit: Rephrase to "This cluster cannot reach a rebalanced state of leaders since 1 of the 3 tservers is in maintenance mode." http://gerrit.cloudera.org:8080/#/c/19608/5/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/19608/5/src/kudu/master/auto_leader_rebalancer.cc@250 PS5, Line 250: which is nit: change to "that are" http://gerrit.cloudera.org:8080/#/c/19608/5/src/kudu/master/auto_leader_rebalancer.cc@250 PS5, Line 250: transfering nit: transferring -- To view, visit http://gerrit.cloudera.org:8080/19608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f85a675e69fd02a62e2625881dad2ca5e27acd9 Gerrit-Change-Number: 19608 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 13 Mar 2023 17:06:15 +0000 Gerrit-HasComments: Yes
