Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to show on creating tables ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG@7 PS2, Line 7: A tool to show on creating tables > Yes You mean this tool is to show list of both tables as well as tablets? On a side note, I was wondering if it is feasible to show list of tables both created or in-process of creation under same list command along with their status. We can add status column that shows two states : In-progress and Completed "In-progress" for those tables/tablets that are in process of creation and "Completed" for those that have already been created successfully. http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG@15 PS2, Line 15: cancel the creating tasks > For example, a Kudu cluster with 3 masters and 3 tservers. if one tserver g I understand the need for cancelation. However, I am not clear on how cancelation of in-progress task happens. Is "cancelation of task" code already in place or needs to be added on top of this. If yes, it would be great if you could point me to the code which takes in "cancel-task" input from user and goes ahead with cancelation by probably de-initialising data structures canceling creation thread. http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/client/client-internal.h@171 PS2, Line 171: list_creating_tables nit: list_tables_being_created -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 20 Mar 2023 12:21:29 +0000 Gerrit-HasComments: Yes
