Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to show on creating tables ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/master/catalog_manager.cc@3929 PS4, Line 3929: tablet_lock.data().is_deleted() || : tablet_lock.data().is_running() tablets in state PREPARING and CREATING are needed, right? how about adding a new function in PersistentTabletInfo for this? http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/master/catalog_manager.cc@3947 PS4, Line 3947: table_info->set_state(SysTablesEntryPB_State_Name(table_lock.data().pb.state())); How about just response pb.state(), transfer to string in CLI tool to reduce the rpc size? http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/kudu-admin-test.cc@1933 PS4, Line 1933: NO_FATALS(BuildAndStart(kTserverFlags, kMasterFlags)); nit: just pass '{}' http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/kudu-admin-test.cc@1983 PS4, Line 1983: ASSERT_STR_CONTAINS(s.ToString(), "Timed out waiting for Table Creation"); nit: add one more check, ASSERT_TRUE(s.IsTimedOut()) << s.ToString(); http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/kudu-admin-test.cc@1999 PS4, Line 1999: ASSERT_STR_CONTAINS(s.ToString(), "Timed out: Timed out waiting for AlterTable"); nit: add one more check, ASSERT_TRUE(s.IsTimedOut()) << s.ToString(); http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/kudu-admin-test.cc@2029 PS4, Line 2029: ASSERT_STR_CONTAINS(std nit: how about use ASSERT_STR_MATCHES? http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/tool.proto@546 PS4, Line 546: 7 Why skip 6? http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/19584/4/src/kudu/tools/tool_action_table.cc@239 PS4, Line 239: return !(FLAGS_list_creating_tables && nit: What's the purpose of this limit? To avoid too large output? Add some hint message like L229. -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 31 Mar 2023 08:37:15 +0000 Gerrit-HasComments: Yes
