Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 )
Change subject: [KUDU-3452] A tool to show on creating tables ...................................................................... Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG@7 PS2, Line 7: tables > Since there two cases, creating tables and adding range partions, so 'table In fact, creating a table is to creating tablets. Table is a logic conception. But this tool shows the information of on creating tables. Please see the commit, there is an output example. http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG@7 PS2, Line 7: A tool to show on creating tables > You mean this tool is to show list of both tables as well as tablets? In fact, creating a table is to creating tablets. Table is a logic conception. But this tool shows the information of on-creating tables. This tool only shows on-creating table not finished table. http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG@11 PS2, Line 11: The creating task will retry continuously for a long : time. > The client side will timeout, but the server side will never timeout. Done http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG@15 PS2, Line 15: cancel the creating tasks > I understand the need for cancelation. However, I am not clear on how cance Currently, I have no clear idea. The creating tables in the tablet server is a series of tasks. Maybe we can interrupt the tasks. But I do not know the risk. That needs some tests. http://gerrit.cloudera.org:8080/#/c/19584/2//COMMIT_MSG@18 PS2, Line 18: kudu table list > nit: 'kudu table list' Done http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/client/client-internal.h@171 PS2, Line 171: list_creating_tables > nit: list_tables_being_created Done http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/client/client-internal.cc@483 PS2, Line 483: list_creating_tables > nit: list_creating_tablets? This tool lists on-creating tables not tablets. http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/client/client-internal.cc@519 PS2, Line 519: if (list_creating_tables) { > CLI tool is allowed to access servers in old version, it's needed to deal t OK. Here, I will check whether the filed 'state' existed to be compatible with the old version of kudu server. http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/client/client-internal.cc@520 PS2, Line 520: info.id = table.id(); > IMO table id is an internal concept, but not user faced, why expose it to e In the future, maybe it needs to cancel the creating task according to the table id. Therefore, here expose the table id to the user. http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/master/catalog_manager.cc@3949 PS2, Line 3949: return Status::OK(); > Why return here, the infos bellow e.g. soft deleted tables, can be skipped Yes. We only need to collect on-creating tables, not need to collect other information. http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/master/master.proto@634 PS2, Line 634: optional bool list_creating_tables = 5; > nit: add '[default = false]' to explictly declare it, deal the case of usin Done http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/19584/2/src/kudu/tools/tool_action_table.cc@281 PS2, Line 281: continue; > It seems --list_creating_tables is not work with some other flags, use GROU Done -- To view, visit http://gerrit.cloudera.org:8080/19584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348b69f48e6ce36ed869097f9f798c5946136de5 Gerrit-Change-Number: 19584 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 27 Mar 2023 11:52:28 +0000 Gerrit-HasComments: Yes
