Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Create tablet without enough healthy tservers ...................................................................... Patch Set 4: (13 comments) http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@10 PS4, Line 10: tablet servers tservers http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@11 PS4, Line 11: unavailabe nit: unavailable http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@11 PS4, Line 11: tserver becomes tservers become http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@15 PS4, Line 15: Create So creating http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@16 PS4, Line 16: when only 2 when there are only 2 healthy tservers http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@16 PS4, Line 16: support nit: supported http://gerrit.cloudera.org:8080/#/c/19571/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/3/src/kudu/master/catalog_manager.cc@5945 PS3, Line 5945: nit: protocol http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc@5988 PS4, Line 5988: nit: unexpected extra space ? http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc@6001 PS4, Line 6001: replica_factor nit: replication_factor http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc@6002 PS4, Line 6002: or Otherwise, http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc@6004 PS4, Line 6004: protocal nit: protocol http://gerrit.cloudera.org:8080/#/c/19571/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/2/src/kudu/tools/kudu-tool-test.cc@9213 PS2, Line 9213: Start()); > Ksck can not make master know that tablet server is offline. Tablet server So?SleepFor (2 * FLAGS_tserver_unresponsive_timeout_ms ) ? And above( L9203) http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/tools/kudu-tool-test.cc@9239 PS4, Line 9239: NO_FATALS(cluster_->Restart()); It's no need restart all kudu cluster. The case should make sure 'cluster_->tablet_server(0)->Start(); ' can resume the unhealthy state. Another way to resume this table to health is adding a new tserver, you can add this case. -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 27 Mar 2023 11:19:33 +0000 Gerrit-HasComments: Yes
