Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Create tablet without enough healthy tservers ...................................................................... Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc@418 PS10, Line 418: enough nit: not enough http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc@5999 PS10, Line 5999: enough What does "enough" mean, does 1 out of RF = 3 is enough? How about to describe "all requested replicas number of" or sth. like that? Besides, the logic below is to update "nreplicas" but not "create a tablet", so how about update the comments to "Update nreplicas if needed." or sth. http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/master/catalog_manager.cc@6008 PS10, Line 6008: ( Remove duplicate brackets. http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9227 PS10, Line 9227: ASSERT_EQ(s.ToString(), nit: Check the type of Status fastly, i.e. : ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString(); http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9234 PS10, Line 9234: // Ksck will be OK. Also check the table 'kOverRegistedTSTableName' is not existed in the cluster? http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9245 PS10, Line 9245: SleepFor(MonoDelta::FromMilliseconds(6000)); It would be better to check the 3 tservers are actually shutdown successflly, maybe ListTabletServers got 3 alive tservers. http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9264 PS10, Line 9264: ASSERT_EQ(s.ToString(), "Timed out: Timed out waiting for Table Creation"); nit: Check the type of Status fastly, i.e. : ASSERT_TRUE(s.IsTimedOut()) << s.ToString(); http://gerrit.cloudera.org:8080/#/c/19571/10/src/kudu/tools/kudu-tool-test.cc@9272 PS10, Line 9272: SleepFor(MonoDelta::FromMilliseconds(4000)); Same, check the 4 tservers are actually alive. -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 24 Apr 2023 03:03:56 +0000 Gerrit-HasComments: Yes
