Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Create tablet without enough healthy tservers ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/19571/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/6/src/kudu/master/catalog_manager.cc@6003 PS6, Line 6003: if (policy.ts_num() < (nreplicas + 1) / 2) { > It has been implemented in Line 6012. 'policy.ts_num()' returns the number of tservers that are available for placement[1], I mean we should also check the number of registered tservers[2]. I guess that if there are enough registered tservers to create all replicas of a table, to some extent it means that some tservers are just temporarily offline and there will eventually be enough available tservers to make the cluster healthy. [1] https://github.com/apache/kudu/blob/f13f6580c0588d8596f76e8ad9e39feba7a13783/src/kudu/master/ts_manager.h#L92-L96 [2] https://github.com/apache/kudu/blob/f13f6580c0588d8596f76e8ad9e39feba7a13783/src/kudu/master/ts_manager.h#L88-L90 -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 07 Apr 2023 03:38:36 +0000 Gerrit-HasComments: Yes
