Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Create tablet without enough healthy tservers ...................................................................... Patch Set 6: (13 comments) http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@11 PS4, Line 11: unavailabl > nit: unavailable Done http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@11 PS4, Line 11: tablet servers > tservers become Done http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@15 PS4, Line 15: le. So > So creating Done http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@16 PS4, Line 16: replicas ta > when there are only 2 healthy tservers Done http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@16 PS4, Line 16: 2 tabl > nit: supported Done http://gerrit.cloudera.org:8080/#/c/19571/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/3/src/kudu/master/catalog_manager.cc@5933 PS3, Line 5933: // NOTE: if we fail to select replicas on the first pass (due to : // insufficient Tablet Servers being online), we will still try : // again unless the tablet/table creation is cancelled. : RETURN_NOT_OK_PREPEND(SelectReplicasForTablet(policy, tablet.get()), : Substitute("error selecting replicas for tablet $0", : tablet->id())); : } : } : : // Update the sys catalog with the new set of tablets/metadata. : { : SysCatalogTable::Actions actions; : actions.tablets_to_add = deferred.tablets_to_add; : actions.tablets_to_update = deferred.tablets_to_update; : RETURN_NOT_OK_PREPEND(sys_catalog_->Write(std::move(actions)), : "error persisting updated tablet metadata"); : } : : // Ex > Done Done http://gerrit.cloudera.org:8080/#/c/19571/3/src/kudu/master/catalog_manager.cc@6006 PS3, Line 6006: "alive tablet servers", > Done Done http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc@5988 PS4, Line 5988: T > nit: unexpected extra space ? Done http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc@6001 PS4, Line 6001: replication_fa > nit: replication_factor Done http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc@6002 PS4, Line 6002: of > Otherwise, Done http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/master/catalog_manager.cc@6004 PS4, Line 6004: protocol > nit: protocol Done http://gerrit.cloudera.org:8080/#/c/19571/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/2/src/kudu/tools/kudu-tool-test.cc@9213 PS2, Line 9213: name(kTableName2 > So?SleepFor (2 * FLAGS_tserver_unresponsive_timeout_ms ) ? And above( L920 tserver_unresponsive_timeout_ms is a server flag. CLI can not get the value directly. http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/4/src/kudu/tools/kudu-tool-test.cc@9239 PS4, Line 9239: > It's no need restart all kudu cluster. The case should make sure 'cluster_ Done -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 28 Mar 2023 03:04:20 +0000 Gerrit-HasComments: Yes
