Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Create tablet without enough healthy tservers ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/19571/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/6/src/kudu/master/catalog_manager.cc@6003 PS6, Line 6003: if (policy.ts_num() < (nreplicas + 1) / 2) { nit: According to discussions in the JIRA ticket, we should also check for the total number of tablet servers registered with the catalog manager, to expose errors of a misconfigured Kudu cluster. http://gerrit.cloudera.org:8080/#/c/19571/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19571/6/src/kudu/tools/kudu-tool-test.cc@9175 PS6, Line 9175: Restart the stopped tserver to bring the table to healthy. nit: How about 'The table will become healthy once the unavailable tserver is brought back online'? http://gerrit.cloudera.org:8080/#/c/19571/6/src/kudu/tools/kudu-tool-test.cc@9290 PS6, Line 9290: colum nit: column -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 06 Apr 2023 09:35:28 +0000 Gerrit-HasComments: Yes
