Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22573 )
Change subject: KUDU-3646 fix Base64Decode() ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22573/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22573/3//COMMIT_MSG@7 PS3, Line 7: fix Base64Decode() > There is a bunch of them now in the updated url-coding-test.cc, Base64Test. I guess what I am trying to say is this - due to this underlying issue in Base64Decode(), there must be some real world scenario that failed in the form of a failed kudu operation/behaviour. Never mind, the jira description kind of answers that by saying "it could lead to unexpected results". If there is one example of such unexpected results, maybe mention that here or in jira description (for posterity and documentation purpose). It is not super important though so feel free to ignore. http://gerrit.cloudera.org:8080/#/c/22573/5/src/kudu/util/url-coding.cc File src/kudu/util/url-coding.cc: http://gerrit.cloudera.org:8080/#/c/22573/5/src/kudu/util/url-coding.cc@212 PS5, Line 212: "non-trailing '=' > No, I don't think so. The idea is to avoid going through all the character Yeah, that's one way to look at it. The idea is to figure out the invalid input case just by looking at the error log in release builds. Since it would require going through the string in release build and may probably turn out to be an unnecessary overhead (I am not sure), I am fine either way. -- To view, visit http://gerrit.cloudera.org:8080/22573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc Gerrit-Change-Number: 22573 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 07 Mar 2025 12:15:26 +0000 Gerrit-HasComments: Yes
