Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22573 )
Change subject: KUDU-3646 fix Base64Decode() ...................................................................... Patch Set 6: (2 comments) > Patch Set 3: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/22573/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22573/3//COMMIT_MSG@7 PS3, Line 7: fix Base64Decode() > If you are interested, below is just another scenario that helps exposing t Thanks! http://gerrit.cloudera.org:8080/#/c/22573/5/src/kudu/util/url-coding.cc File src/kudu/util/url-coding.cc: http://gerrit.cloudera.org:8080/#/c/22573/5/src/kudu/util/url-coding.cc@212 PS5, Line 212: "non-trailing '=' > In the long run, if you are interested in replacing this ad-hoc implementat Yes, cppcodec does take care of such cases better. I'll try to take crack at it in next on-call. -- To view, visit http://gerrit.cloudera.org:8080/22573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc Gerrit-Change-Number: 22573 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 10 Mar 2025 15:28:41 +0000 Gerrit-HasComments: Yes
