Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22573 )

Change subject: KUDU-3646 fix Base64Decode()
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22573/6/src/kudu/util/url-coding.cc
File src/kudu/util/url-coding.cc:

http://gerrit.cloudera.org:8080/#/c/22573/6/src/kudu/util/url-coding.cc@185
PS6, Line 185:  for (; padding_it != in.crend(); ++padding_it) {
> That exactly what's going on in the code that you highlighted.
Ah, great. Thanks for that.



--
To view, visit http://gerrit.cloudera.org:8080/22573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc
Gerrit-Change-Number: 22573
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Mon, 10 Mar 2025 22:26:48 +0000
Gerrit-HasComments: Yes

Reply via email to