Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22573 )
Change subject: KUDU-3646 fix Base64Decode() ...................................................................... KUDU-3646 fix Base64Decode() Prior to this patch, Base64Decode() in src/kudu/util/url-coding.cc had a bug that lead to truncating the output data by discarding trailing null/zero bytes. Originally imported from the Impala's codebase [1], the bug has been lurking for 11+ years in the Kudu's codebase. Meanwhile, Impala fixed the issue a long time ago [2]. This patch addresses the issue and adds corresponding test coverage. In addition, this patch adds extra validation for the input of Base64Decode() and provides test coverage for that as well. Also, reference binding to null pointer in url-coding-test.cc has been addressed as well. [1] https://github.com/apache/kudu/commit/ce4d760ca [2] https://issues.apache.org/jira/browse/IMPALA-2878 Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc Reviewed-on: http://gerrit.cloudera.org:8080/22573 Reviewed-by: Ashwani Raina <[email protected]> Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/util/url-coding-test.cc M src/kudu/util/url-coding.cc M src/kudu/util/url-coding.h 3 files changed, 132 insertions(+), 15 deletions(-) Approvals: Ashwani Raina: Looks good to me, but someone else must approve Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc Gerrit-Change-Number: 22573 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
