Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22573 )
Change subject: KUDU-3646 fix Base64Decode() ...................................................................... Patch Set 5: (2 comments) Thank you for the feedback! http://gerrit.cloudera.org:8080/#/c/22573/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22573/3//COMMIT_MSG@7 PS3, Line 7: fix Base64Decode() > I guess what I am trying to say is this - due to this underlying issue in B Ah, that's a good point, indeed. I've just filed KUDU-3648 to reflect on a real world scenario that's caused by this bug. http://gerrit.cloudera.org:8080/#/c/22573/5/src/kudu/util/url-coding.cc File src/kudu/util/url-coding.cc: http://gerrit.cloudera.org:8080/#/c/22573/5/src/kudu/util/url-coding.cc@212 PS5, Line 212: "non-trailing '=' > Yeah, that's one way to look at it. In the long run, if you are interested in replacing this ad-hoc implementation with something more performant and more robust in error handling, please take a look at https://github.com/tplgy/cppcodec (it's a header-only library). I might think of importing it as a 3rd-party component and using for base64 encoding/decoding instead of this boost-based implementation. -- To view, visit http://gerrit.cloudera.org:8080/22573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5d41eb4e41897d520f00b12c6e487ecc5a00fc Gerrit-Change-Number: 22573 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 07 Mar 2025 18:38:16 +0000 Gerrit-HasComments: Yes
