> On May 16, 2015, 12:31 p.m., Joris Van Remoortere wrote:
> > src/tests/sched_tests.cpp, line 40
> > <https://reviews.apache.org/r/34309/diff/1/?file=961961#file961961line40>
> >
> >     Could you elaborate on this comment and explain what you are testing in 
> > the child? I don't think it's clear.
> >     
> >     Should we also test the inheritance? (i.e. fork while in the IDLE 
> > policy, and then verify in the child?)

It's testing that we can set the policy for a child/different process, not that 
a child process can set its own policy. I amended the comment to make that 
clearer.

Regarding inheritance, this is specified for sched_setscheduler() and I'm not 
sure I want to get into the business of testing every system call ;-) ?

"Child processes inherit the scheduling policy and parameters across a fork(2). 
 The scheduling policy and parameters are preserved across execve(2)."


> On May 16, 2015, 12:31 p.m., Joris Van Remoortere wrote:
> > src/tests/sched_tests.cpp, line 30
> > <https://reviews.apache.org/r/34309/diff/1/?file=961961#file961961line30>
> >
> >     Do you want to add a TODO for some tests that:
> >     1) Actually test that the priority / interruption behavior is as 
> > expected
> >     2) Shows people how to use this / explains how it works
> >     
> >     I think 1) and 2) can be done in the same test with nice comments :-)

Added a TODO.

Testing priority is easy. Do you have suggestions on how to test preemption 
behavior?


> On May 16, 2015, 12:31 p.m., Joris Van Remoortere wrote:
> > src/linux/sched.hpp, line 53
> > <https://reviews.apache.org/r/34309/diff/1/?file=961960#file961960line53>
> >
> >     Should we add the pid for which this failed to the error message?

I think the caller should be responsible for this?


> On May 16, 2015, 12:31 p.m., Joris Van Remoortere wrote:
> > src/linux/sched.hpp, line 73
> > <https://reviews.apache.org/r/34309/diff/1/?file=961960#file961960line73>
> >
> >     Should we add the pid for which this failed to the error message?

I think the caller should be responsible for this?


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84038
-----------------------------------------------------------


On May 18, 2015, 10:33 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34309/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 10:33 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2652
>     https://issues.apache.org/jira/browse/MESOS-2652
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support manipulating scheduler policy on Linux.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 
>   src/linux/sched.hpp PRE-CREATION 
>   src/tests/sched_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34309/diff/
> 
> 
> Testing
> -------
> 
> Added test.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to