> On May 19, 2015, 9:53 a.m., Niklas Nielsen wrote:
> > src/tests/sched_tests.cpp, line 45
> > <https://reviews.apache.org/r/34309/diff/2/?file=963182#file963182line45>
> >
> >     Any reason not to use the fork abstraction? If not, want to explicitly 
> > use ::fork()?

I only want a single child so the Fork abstraction is OTT IMHO. Changed to 
::fork to be explicit.


> On May 19, 2015, 9:53 a.m., Niklas Nielsen wrote:
> > src/tests/sched_tests.cpp, line 34
> > <https://reviews.apache.org/r/34309/diff/2/?file=963182#file963182line34>
> >
> >     Can you go in a bit more detail about what this test does? What is the 
> > point of starting the children and having them sleep and change the parent 
> > sched policy?

It's testing we can set the scheduling policy for a different process to the 
caller. I split this into a second test to make it clearer.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84331
-----------------------------------------------------------


On May 18, 2015, 1:48 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34309/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 1:48 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2652
>     https://issues.apache.org/jira/browse/MESOS-2652
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support manipulating scheduler policy on Linux.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 
>   src/linux/sched.hpp PRE-CREATION 
>   src/tests/sched_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34309/diff/
> 
> 
> Testing
> -------
> 
> Added test.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to