> On May 19, 2015, 4:53 p.m., Niklas Nielsen wrote: > > src/linux/sched.hpp, line 51 > > <https://reviews.apache.org/r/34309/diff/2/?file=963181#file963181line51> > > > > Want to add some context to which pid that you couldn't get the policy > > for? For example: "Failed to get scheduler policy for pid: 1234" > > Vinod Kone wrote: > Nik, the general rule is that we don't include stuff in the log message > that the caller already has access to, because it makes it hard to chain > errors (e.g., the caller has no idea whether to include pid in its own log > message or not). > > Niklas Nielsen wrote: > Okay - didn't know. Should we put this in the style guide then? > > We don't print the pid in the call site either in: > https://reviews.apache.org/r/34310
+1 to updating style guide. regarding caller not printing pid: it's up to the caller. and yea, it makes sense for the caller to print pid in this specific case. cc @idownes. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/#review84331 ----------------------------------------------------------- On May 19, 2015, 7:58 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34309/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 7:58 p.m.) > > > Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-2652 > https://issues.apache.org/jira/browse/MESOS-2652 > > > Repository: mesos > > > Description > ------- > > Support manipulating scheduler policy on Linux. > > > Diffs > ----- > > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > src/linux/sched.hpp PRE-CREATION > src/tests/sched_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34309/diff/ > > > Testing > ------- > > Added test. > > > Thanks, > > Ian Downes > >
