> On May 19, 2015, 4:53 p.m., Niklas Nielsen wrote:
> > src/linux/sched.hpp, line 51
> > <https://reviews.apache.org/r/34309/diff/2/?file=963181#file963181line51>
> >
> >     Want to add some context to which pid that you couldn't get the policy 
> > for? For example: "Failed to get scheduler policy for pid: 1234"

Nik, the general rule is that we don't include stuff in the log message that 
the caller already has access to, because it makes it hard to chain errors 
(e.g., the caller has no idea whether to include pid in its own log message or 
not).


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84331
-----------------------------------------------------------


On May 18, 2015, 8:48 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34309/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 8:48 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2652
>     https://issues.apache.org/jira/browse/MESOS-2652
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support manipulating scheduler policy on Linux.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 
>   src/linux/sched.hpp PRE-CREATION 
>   src/tests/sched_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34309/diff/
> 
> 
> Testing
> -------
> 
> Added test.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to