> On May 19, 2015, 11:49 a.m., Vinod Kone wrote: > > can you please make sure to run 'make check' on OSX?
It makes and tests clean on OSX; did you see something different? ``` $ make check .... [----------] Global test environment tear-down [==========] 570 tests from 86 test cases ran. (123273 ms total) [ PASSED ] 570 tests. YOU HAVE 7 DISABLED TESTS Making check in ec2 make[1]: Nothing to be done for `check'. $ uname -v Darwin Kernel Version 13.4.0: Wed Mar 18 16:20:14 PDT 2015; root:xnu-2422.115.14~1/RELEASE_X86_64 ``` > On May 19, 2015, 11:49 a.m., Vinod Kone wrote: > > src/Makefile.am, line 539 > > <https://reviews.apache.org/r/34309/diff/2/?file=963180#file963180line539> > > > > should be inside "if OS_LINUX" above at #459? That's for source only? We've put all the other linux/*.hpp here. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/#review84359 ----------------------------------------------------------- On May 18, 2015, 1:48 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34309/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 1:48 p.m.) > > > Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-2652 > https://issues.apache.org/jira/browse/MESOS-2652 > > > Repository: mesos > > > Description > ------- > > Support manipulating scheduler policy on Linux. > > > Diffs > ----- > > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > src/linux/sched.hpp PRE-CREATION > src/tests/sched_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34309/diff/ > > > Testing > ------- > > Added test. > > > Thanks, > > Ian Downes > >
