> On May 13, 2015, 11:19 a.m., Adam B wrote:
> > src/master/http.cpp, lines 279-288
> > <https://reviews.apache.org/r/30612/diff/15/?file=947349#file947349line279>
> >
> >     One thing I'm not 100% clear about from this description: Are each of 
> > these levels strict subsets of the json hierarchy, or e.g. is there any 
> > data in the result from `/master/frameworks/{fid}` that is not included in 
> > `/master/frameworks`?
> 
> Alexander Rojas wrote:
>     The are indeed subsets, but I don't see the value of explicitly 
> mentioning it. Can you explain why you thing that is important?

I hope the new wording makes this clearer.


> On May 13, 2015, 11:19 a.m., Adam B wrote:
> > src/master/http.cpp, line 322
> > <https://reviews.apache.org/r/30612/diff/15/?file=947349#file947349line322>
> >
> >     What about completed frameworks? Should they use this endpoint too, or 
> > would they get their own?
> 
> Till Toenshoff wrote:
>     Right now we would like to make this a TODO and discuss it more 
> thorroughly within the community. We are a bit concerned that such extension 
> of this endpoint would trigger the same issues (long long loading time) we 
> have had with stats. What do you think?

As mentioned by Till, I will drop this and open a JIRA once this patch gets 
commited.


> On May 13, 2015, 11:19 a.m., Adam B wrote:
> > src/master/http.cpp, line 340
> > <https://reviews.apache.org/r/30612/diff/15/?file=947349#file947349line340>
> >
> >     Completed tasks?

As mentioned above by Till, I will drop this and open a JIRA once this patch 
gets commited.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review83122
-----------------------------------------------------------


On May 29, 2015, 4:47 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 4:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Marco Massenzio, Niklas 
> Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2157
>     https://issues.apache.org/jira/browse/MESOS-2157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
> 
> Adds tests for the endpoints.
> 
> Works with [29883](https://reviews.apache.org/r/29883).
> 
> Builds on the abandoned patch 14286.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 
>   src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d 
>   src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b 
> 
> Diff: https://reviews.apache.org/r/30612/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to