-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review95156
-----------------------------------------------------------

Ship it!



src/master/master.hpp (line 475)
<https://reviews.apache.org/r/37175/#comment149996>

    MachineInfo



src/master/master.cpp (line 4038)
<https://reviews.apache.org/r/37175/#comment149997>

    MachineInfo



src/master/master.cpp (line 4066)
<https://reviews.apache.org/r/37175/#comment149992>

    Maybe have a check for:
    `Try<Duration> duration = 
Druation::create(unavailability.get().duration());`


- Joseph Wu


On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp 
> aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 
> e278139f856888d6c6f538f7c0f664087e97f629 
>   src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3 
>   src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 
>   src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 
>   src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 
> 
> Diff: https://reviews.apache.org/r/37175/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to