----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review96540 -----------------------------------------------------------
src/docker/docker.cpp (line 1077) <https://reviews.apache.org/r/37703/#comment151985> In what situation would we want to enable tty? src/docker/docker.cpp (line 1082) <https://reviews.apache.org/r/37703/#comment151984> put the detach value in another argv push_back, same as the tty src/docker/docker.cpp (line 1091) <https://reviews.apache.org/r/37703/#comment151986> I'm not sure this is needed since we already want to wrap the command in shell anyways src/tests/containerizer/docker_tests.cpp (line 135) <https://reviews.apache.org/r/37703/#comment151983> Can you create a seperate test for exec? And we then do a version check in the test. - Timothy Chen On Aug. 22, 2015, 6:02 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37703/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2015, 6:02 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3291 > https://issues.apache.org/jira/browse/MESOS-3291 > > > Repository: mesos > > > Description > ------- > > Add docker exec command. > > > Diffs > ----- > > src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e > src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 > src/tests/containerizer/docker_tests.cpp > a4a2725c05ae0cb88426c587f7ded0da77154edc > > Diff: https://reviews.apache.org/r/37703/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
