----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review103458 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 39) <https://reviews.apache.org/r/39005/#comment161519> s/version/versions/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 41) <https://reviews.apache.org/r/39005/#comment161520> Can we use parallel constructs and make it "one from XSI which ..." 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 61) <https://reviews.apache.org/r/39005/#comment161521> s/version/versions/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 77) <https://reviews.apache.org/r/39005/#comment161522> s/\0/'\0'/ - Kapil Arya On Oct. 9, 2015, 10:24 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39005/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 10:24 a.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3551 > https://issues.apache.org/jira/browse/MESOS-3551 > > > Repository: mesos > > > Description > ------- > > This adds a thread-safe wrapper around strerror_r which has semantics similar > to strerror. We plan to use this at call sites currently relying on strerror. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e > > Diff: https://reviews.apache.org/r/39005/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
