> On Oct. 21, 2015, 10:23 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 41 > > <https://reviews.apache.org/r/39005/diff/3/?file=1093870#file1093870line41> > > > > Can we fix the #include order as mentioned in the followup RR?
Let's keep lexicographical sort with an ASCII code page (which plays nicely with everything from `sort` to `clang-format`) while the discussion for the coding guidelines MESOS-2275 is still in flux. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review103484 ----------------------------------------------------------- On Oct. 9, 2015, 2:24 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39005/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 2:24 p.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3551 > https://issues.apache.org/jira/browse/MESOS-3551 > > > Repository: mesos > > > Description > ------- > > This adds a thread-safe wrapper around strerror_r which has semantics similar > to strerror. We plan to use this at call sites currently relying on strerror. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e > > Diff: https://reviews.apache.org/r/39005/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
