----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review103566 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 29) <https://reviews.apache.org/r/39005/#comment161643> Mention that the buffer is thread local. 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (lines 49 - 52) <https://reviews.apache.org/r/39005/#comment161642> Suggestion: > Implementations of strerror_r from glibc-2.15 or earlier which do not define _GNU_SOURCE and define _POSIX_C_SOURCE=200112L contain a bug where the global errno is illegally modify whenever strerr_r run into errors itself. - Alexander Rojas On Oct. 22, 2015, 9:46 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39005/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 9:46 a.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3551 > https://issues.apache.org/jira/browse/MESOS-3551 > > > Repository: mesos > > > Description > ------- > > This adds a thread-safe wrapper around strerror_r which has semantics similar > to strerror. We plan to use this at call sites currently relying on strerror. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ba2836a72ceee948cb43364e80ada9f132f33d04 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff > > Diff: https://reviews.apache.org/r/39005/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
