----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review106230 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 40) <https://reviews.apache.org/r/39005/#comment164970> This preprocessor wrangling and its comment can be moved outside the function, which thus becomes more readable by itself. 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 78) <https://reviews.apache.org/r/39005/#comment164971> s/was/has been "likely" isn't strong enough a word here. Just delete it. - Bernd Mathiske On Nov. 4, 2015, 6:37 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39005/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 6:37 a.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3551 > https://issues.apache.org/jira/browse/MESOS-3551 > > > Repository: mesos > > > Description > ------- > > This commit also adds test cases for os::strerror (from stout) which can > only be committed with a libprocess commit -- the corresponding Makefile > lives there. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 76e1674e08bbe65a4fdf86731823a61f231d6d12 > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 26e1377ee625748b7fdbec327fef9ac602535f83 > 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39005/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
