-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review104697
-----------------------------------------------------------

Ship it!



src/master/master.hpp (line 842)
<https://reviews.apache.org/r/36913/#comment162950>

    How about 
    s/It/A single instance of this class/
    ?



src/master/master.hpp (line 853)
<https://reviews.apache.org/r/36913/#comment162951>

    Why do you want to remove this check? For me it looks useful enough: it's 
an internal invariant.



src/master/master.hpp (lines 1018 - 1019)
<https://reviews.apache.org/r/36913/#comment162952>

    Newline?


- Alexander Rukletsov


On Oct. 22, 2015, 1:03 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to