> On Nov. 2, 2015, 4:43 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 84
> > <https://reviews.apache.org/r/39285/diff/6/?file=1105159#file1105159line84>
> >
> >     Mind adding a comment this is a "reference" role which is deduced from 
> > the resources in the request and is not specified directly? For example:
> >     
> >     ```
> >     // A role for which quota request is sent. Currently only one role per 
> > request is allowed. Since an operator does not specify role explicitly, it 
> > is deduced from the provided resources.
> >     ```
> 
> Guangya Liu wrote:
>     Alex, I think that we should treat the role as explicitly specified in 
> the http request as the http request does include roles for the quota. The 
> operator does specify the role explicitly in the http request, comments?

We agreed (in the design doc) that extra specification of a role is not 
necessary because of two reasons:
- it's already specified in each `Resource` instance
- it does not contraint us to support multiple roles per request if we want it 
one day

If you have a strong preference or arguments against this approach, please open 
a separate issue and let's discuss it there!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review104725
-----------------------------------------------------------


On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 7:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to