> On Nov. 3, 2015, 1:37 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 123 > > <https://reviews.apache.org/r/39285/diff/6/?file=1105159#file1105159line123> > > > > Suggest to change ```if``` to ```else if```, in this way, for the first > > resource, we do not need to compare it with itself.
I personally find the non else version easier to read as it is just a sequence of conditions being checked, but changed it anyhow. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review104906 ----------------------------------------------------------- On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 7:42 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > Added Quota Request Validation. > > > Diffs > ----- > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
