> On Nov. 2, 2015, 8:43 a.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 148-149 > > <https://reviews.apache.org/r/39285/diff/6/?file=1105159#file1105159line148> > > > > As per @joris' comment in the previous review, should we check for > > errors after `.get()` calls?
I agree. You're effectively double-converting JSON->Protobuf. Note that you can put `google::protobuf::RepeatedPtrField` in a `foreach`. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review104725 ----------------------------------------------------------- On Oct. 24, 2015, 12:42 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 12:42 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > Added Quota Request Validation. > > > Diffs > ----- > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
