> On Nov. 5, 2015, 9:59 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, lines 102-110 > > <https://reviews.apache.org/r/39285/diff/6/?file=1105159#file1105159line102> > > > > What do you think about using helpers from > > `include/mesos/resources.hpp`? A bunch of these checks could be done on a > > `Resources` (plural) object.
I considered them but decided against them for the following reasons - I really jsut want to check whether such additional field has been specified, consider for example 'isPersistentVolume' which also checks for persistence. Hence I would need to chech .has_disk() anyhow. - Others seem like very trivial wrappers (e.g. isRevocable -> return resource.has_revocable()) in which case I would like to have one consistent way across all checks (which due the above point is checking the protobug fields without the helpers). - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105313 ----------------------------------------------------------- On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 7:42 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > Added Quota Request Validation. > > > Diffs > ----- > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
