> On Nov. 6, 2015, 4:19 p.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 180
> > <https://reviews.apache.org/r/39285/diff/7/?file=1118136#file1118136line180>
> >
> >     Should we move it into `validateQuotaRequest`? If any role is exist in 
> > master, we did not need to continue to check others. And in QuotaHandler, 
> > we had the pointer to master `Master* master`.

I'd keep it here, because it's related to how we currently process the request, 
rather than whether the request is valid.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105440
-----------------------------------------------------------


On Nov. 6, 2015, 3:23 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to