> On Nov. 1, 2015, 8:14 p.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1005
> > <https://reviews.apache.org/r/39401/diff/7/?file=1112398#file1112398line1005>
> >
> >     For this TODO, what do we plan to do in future? Include the dynamic 
> > reserved resources for this role on this agent in 
> > ```roleConsumedResources```? And what about the static reserved resources?
> 
> Alexander Rukletsov wrote:
>     Dynamic reservations should account towards role's quota. [Note about 
> static 
> reservations](https://docs.google.com/document/d/16iRNmziasEjVOblYp5bbkeBZ7pnjNlaIzPQqMTHQ-9I/edit?pli=1#heading=h.xumvch9xiky2)

So when we check if a role's quota is satisfied or not, we will add the role's 
allocated resources with the role's dynamically reserved resources, and check 
if the sum contains the role's quota. But for role's statically reserved 
resources, we will consider they are part of quota. So in future (after these 
TODOs are handled) when we check if a role's quota is satified or not, the 
formula should be ```(role's allocated resource + role's dynamically reserved 
resources) > (role's quota + role's statically reserved resources)```, right?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review104656
-----------------------------------------------------------


On Nov. 2, 2015, 11:16 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 11:16 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to