> On Nov. 12, 2015, 12:25 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp, line 40 > > <https://reviews.apache.org/r/39005/diff/7/?file=1115694#file1115694line40> > > > > This preprocessor wrangling and its comment can be moved outside the > > function, which thus becomes more readable by itself.
I think this is much clearer now after the rewrite. Note that now we actually filter for GLIBC vs. XSI instead of for the buggy version from GLIBC. > On Nov. 12, 2015, 12:25 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp, line 78 > > <https://reviews.apache.org/r/39005/diff/7/?file=1115694#file1115694line78> > > > > s/was/has been > > > > "likely" isn't strong enough a word here. Just delete it. The comment is gone after the rewrite. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review106230 ----------------------------------------------------------- On Nov. 12, 2015, 3:13 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39005/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 3:13 p.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3551 > https://issues.apache.org/jira/browse/MESOS-3551 > > > Repository: mesos > > > Description > ------- > > This commit also adds test cases for os::strerror (from stout) which can > only be committed with a libprocess commit -- the corresponding Makefile > lives there. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 76e1674e08bbe65a4fdf86731823a61f231d6d12 > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 741639a942971e48e2dac42db238d423e61cac21 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 26e1377ee625748b7fdbec327fef9ac602535f83 > 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39005/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
